ezri/dbus-fast
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: improve performance of unmarshalling boolean Variants (#431)

Browse Source 
* feat: improve performance of boolean Variants

There are only two of these type and relatively common
so we can use pre-constructed objects

* chore: tweaks
This commit is contained in:
J. Nick Koston 2025-03-22 16:03:56 -10:00 committed by GitHub
parent 1988984398
commit 888a3c3ea5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/dbus_fast/_private/unmarshaller.pxd
View File

@ -109,6 +109,9 @@ cdef unsigned int TOKEN_LEFT_PAREN_AS_INT
cdef object MARSHALL_STREAM_END_ERROR cdef object MARSHALL_STREAM_END_ERROR
cdef object DEFAULT_BUFFER_SIZE cdef object DEFAULT_BUFFER_SIZE
cdef Variant VARIANT_BOOL_TRUE
cdef Variant VARIANT_BOOL_FALSE
cdef list _EMPTY_HEADERS cdef list _EMPTY_HEADERS
cdef cython.uint EAGAIN cdef cython.uint EAGAIN
@ -178,7 +181,7 @@ cdef class Unmarshaller:
cpdef read_boolean(self, SignatureType type_) cpdef read_boolean(self, SignatureType type_)
cdef _read_boolean(self) cdef bint _read_boolean(self)
cpdef read_uint32_unpack(self, SignatureType type_) cpdef read_uint32_unpack(self, SignatureType type_)

6
src/dbus_fast/_private/unmarshaller.py
View File

@ -120,6 +120,10 @@ TOKEN_LEFT_CURLY_AS_INT = ord("{")
TOKEN_LEFT_PAREN_AS_INT = ord("(") TOKEN_LEFT_PAREN_AS_INT = ord("(")
VARIANT_BOOL_TRUE = Variant._factory(SIGNATURE_TREE_B, True)
VARIANT_BOOL_FALSE = Variant._factory(SIGNATURE_TREE_B, False)
ARRAY = array.array ARRAY = array.array
SOL_SOCKET = socket.SOL_SOCKET SOL_SOCKET = socket.SOL_SOCKET
SCM_RIGHTS = socket.SCM_RIGHTS SCM_RIGHTS = socket.SCM_RIGHTS
@ -539,7 +543,7 @@ class Unmarshaller:
if token_as_int == TOKEN_S_AS_INT: if token_as_int == TOKEN_S_AS_INT:
return Variant._factory(SIGNATURE_TREE_S, self._read_string_unpack()) return Variant._factory(SIGNATURE_TREE_S, self._read_string_unpack())
if token_as_int == TOKEN_B_AS_INT: if token_as_int == TOKEN_B_AS_INT:
return Variant._factory(SIGNATURE_TREE_B, self._read_boolean()) return VARIANT_BOOL_TRUE if self._read_boolean() else VARIANT_BOOL_FALSE
if token_as_int == TOKEN_O_AS_INT: if token_as_int == TOKEN_O_AS_INT:
return Variant._factory(SIGNATURE_TREE_O, self._read_string_unpack()) return Variant._factory(SIGNATURE_TREE_O, self._read_string_unpack())
if token_as_int == TOKEN_U_AS_INT: if token_as_int == TOKEN_U_AS_INT: