ezri/dbus-fast
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: make ErrorType enums compare as strings (#269)

Browse Source 
The DBusError exception stores the error type as string. This makes the
exception not directly compare to the ErrorType members (for example
DBusError(ErrorType.FAILED, "").type != ErrorType.FAILED). This makes
ErrorType also a string to make this comparision work.
This commit is contained in:
Stefan Agner 2023-11-22 09:26:11 +01:00 committed by GitHub
parent 6143cb1e86
commit c6a8301704
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dbus_fast/constants.py
View File

@ -91,7 +91,7 @@ class ArgDirection(Enum):
OUT = "out"
class ErrorType(Enum):
class ErrorType(str, Enum):
"""An enum for the type of an error for a message reply.
:seealso: http://man7.org/linux/man-pages/man3/sd-bus-errors.3.html

8
tests/test_constants.py
View File

@ -1,6 +1,12 @@
from dbus_fast.constants import MESSAGE_FLAG_MAP, MessageFlag
from dbus_fast.constants import MESSAGE_FLAG_MAP, ErrorType, MessageFlag
from dbus_fast.errors import DBusError
def test_message_flag_map():
assert 0 in MESSAGE_FLAG_MAP
assert MessageFlag.NONE in MESSAGE_FLAG_MAP
def test_error_type():
err = DBusError(ErrorType.FAILED, "")
assert ErrorType.FAILED == err.type