feat: only construct handlers once (#175)

src/dbus_fast/message_bus.py

@@ -155,7 +155,7 @@ class BaseMessageBus:
                 )
 
         self._path_exports[path].append(interface)
-        ServiceInterface._add_bus(interface, self)
+        ServiceInterface._add_bus(interface, self, self._make_method_handler)
         self._emit_interface_added(path, interface)
 
     def unexport(
@@ -912,7 +912,7 @@ class BaseMessageBus:
                         and msg.member == method.name
                         and msg.signature == method.in_signature
                     ):
-                        handler = self._make_method_handler(interface, method)
+                        handler = ServiceInterface._get_handler(interface, method, self)
                         break
                 if handler:
                     break

src/dbus_fast/service.py

@@ -2,7 +2,15 @@ import asyncio
 import copy
 import inspect
 from functools import wraps
-from typing import Any, Dict, List, no_type_check_decorator
+from typing import (
+    TYPE_CHECKING,
+    Any,
+    Callable,
+    Dict,
+    List,
+    Set,
+    no_type_check_decorator,
+)
 
 from . import introspection as intr
 from ._private.util import (
@@ -13,8 +21,12 @@ from ._private.util import (
 )
 from .constants import PropertyAccess
 from .errors import SignalDisabledError
+from .message import Message
 from .signature import SignatureBodyMismatchError, Variant, get_signature_tree
 
+if TYPE_CHECKING:
+    from .message_bus import BaseMessageBus
+
 
 class _Method:
     def __init__(self, fn, name, disabled=False):
@@ -331,6 +343,10 @@ class ServiceInterface:
         self.__properties: List[_Property] = []
         self.__signals: List[_Signal] = []
         self.__buses = set()
+        self.__handlers: dict[
+            BaseMessageBus,
+            dict[_Method, Callable[[Message, Callable[[Message], None]], None]],
+        ] = {}
 
         for name, member in inspect.getmembers(type(self)):
             member_dict = getattr(member, "__dict__", {})
@@ -437,16 +453,33 @@ class ServiceInterface:
         return interface.__signals
 
     @staticmethod
-    def _get_buses(interface: "ServiceInterface"):
+    def _get_buses(interface: "ServiceInterface") -> Set["BaseMessageBus"]:
         return interface.__buses
 
     @staticmethod
-    def _add_bus(interface: "ServiceInterface", bus) -> None:
-        interface.__buses.add(bus)
+    def _get_handler(
+        interface: "ServiceInterface", method: _Method, bus: "BaseMessageBus"
+    ) -> Callable[[Message, Callable[[Message], None]], None]:
+        return interface.__handlers[bus][method]
 
     @staticmethod
-    def _remove_bus(interface: "ServiceInterface", bus) -> None:
+    def _add_bus(
+        interface: "ServiceInterface",
+        bus: "BaseMessageBus",
+        maker: Callable[
+            ["ServiceInterface", _Method],
+            Callable[[Message, Callable[[Message], None]], None],
+        ],
+    ) -> None:
+        interface.__buses.add(bus)
+        interface.__handlers[bus] = {
+            method: maker(interface, method) for method in interface.__methods
+        }
+
+    @staticmethod
+    def _remove_bus(interface: "ServiceInterface", bus: "BaseMessageBus") -> None:
         interface.__buses.remove(bus)
+        del interface.__handlers[bus]
 
     @staticmethod
     def _msg_body_to_args(msg):