diff --git a/keyboards/lotus/config.h b/keyboards/lotus/config.h index 0e4a4f4aef..1a0d7e9de9 100644 --- a/keyboards/lotus/config.h +++ b/keyboards/lotus/config.h @@ -31,7 +31,7 @@ #endif // PWM single one backlight configuration -// The RP2040 datasheet says GPIO25 maps to PWM channel 4B +// GPIO25 maps to PWM channel 4B of the RP2040 // On the Raspberry Pi Pico this is the green LED on the board, good for prototyping #define BACKLIGHT_PWM_DRIVER PWMD4 #define BACKLIGHT_PWM_CHANNEL RP2040_PWM_CHANNEL_B diff --git a/keyboards/lotus/matrix.c b/keyboards/lotus/matrix.c index a315b966cd..2bf7641311 100644 --- a/keyboards/lotus/matrix.c +++ b/keyboards/lotus/matrix.c @@ -500,6 +500,8 @@ bool matrix_scan_custom(matrix_row_t current_matrix[]) { //uprintf("ADC Voltage: "); //print_as_float(adc_voltage); + // Go through every matrix column (KSO) and drive them low individually + // Then go through every matrix row (KSI), select it with the mux and check their ADC value for (int col = 0; col < MATRIX_COLS; col++) { // Drive column low so we can measure the resistors on each row in this column drive_col(col, false); diff --git a/keyboards/lotus/rules.mk b/keyboards/lotus/rules.mk index 23f2126667..44ab5d852a 100644 --- a/keyboards/lotus/rules.mk +++ b/keyboards/lotus/rules.mk @@ -1,10 +1,14 @@ +# VIA support uses raw HID, don't need to enable it extra. +# Only when disabling VIA but still wanting to use RAW, need to enable it here. VIA_ENABLE = yes RAW_ENABLE = no # Enabled in info.json # EXTRAKEY_ENABLE = yes # Audio control and System control -# Keep it enabled for all, at the moment. Because The rpi-pico has an LED that I can use for debugging +# Enable for all. ANSI keyboard supports RGB and white, gridpad only RGB, all others only white. +# No harm in enabling it for all. +# Also RP pico has the built-in LED wired to the same GPIO. Good for prototyping BACKLIGHT_ENABLE = yes BACKLIGHT_DRIVER = pwm